Fix hotkeys menu crash + New/Fixed keybind support #6565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR fixes a crash when using the search by key feature in the Keybinds window when the panel is filtered, and maps a bunch of keys to byond bindings.
Of note, there are three locations remapping keys:
https://github.com/cmss13-devs/cmss13/blob/master/tgui/packages/tgui/interfaces/KeyBinds.jsx#L14-L26
https://github.com/cmss13-devs/cmss13/blob/master/tgui/packages/common/keys.ts#L20-L39
https://github.com/cmss13-devs/cmss13/blob/master/code/_globalvars/lists/client.dm#L7-L23
Since the first two are as they are on TG, I opted to update the third one which seems to be unique to our codebase
Explain why it's good for the game
Fixes various keybinds (namely keypad stuff), adds a bunch of new keybinds (media keys), and fixes a tgui crash.
Fixes:
Testing Photographs and Procedure
Screenshots & Videos
Changelog
🆑 Drathek
fix: Fixed a crash in the Hotkey menu when searching by key when filtered
fix: Fixed/Added support for various keys (e.g. keypad and media keys)
/:cl: